Update app.py

app.py

@@ -33,22 +33,32 @@ from features.chatbot.chatbot_handler import generate_llm_response
 
 # --- AGENTIC PIPELINE (DISPLAY ONLY) IMPORTS ---
 try:
-    # UPDATED: Using the new display function to show pre-computed results
+    # This is the main function called on initial load to populate the agentic tabs
     from run_agentic_pipeline import load_and_display_agentic_results
-    # ADDED: Import the new report formatter
-    from ui.insights_ui_generator import format_single_okr_for_display, format_report_for_display
+    # This function is now called when a new report is selected from the dropdown
+    from services.report_data_handler import fetch_and_reconstruct_data_from_bubble
+    # UI formatting functions
+    from ui.insights_ui_generator import (
+        format_report_for_display,
+        extract_key_results_for_selection,
+        format_single_okr_for_display
+    )
     AGENTIC_MODULES_LOADED = True
 except ImportError as e:
     logging.error(f"Could not import agentic pipeline display modules: {e}. Tabs 3 and 4 will be disabled.")
     AGENTIC_MODULES_LOADED = False
-    # Placeholder for the new function name if imports fail
+    # Placeholder functions to prevent app from crashing if imports fail
     def load_and_display_agentic_results(*args, **kwargs):
-        # This tuple matches the expected number of outputs for the event handler
         return "Modules not loaded.", gr.update(), "Modules not loaded.", "Modules not loaded.", None, [], [], "Error"
-    def format_single_okr_for_display(okr_data, **kwargs):
-        return "Agentic modules not loaded. OKR display unavailable."
+    def fetch_and_reconstruct_data_from_bubble(*args, **kwargs):
+        return None
     def format_report_for_display(report_data):
         return "Agentic modules not loaded. Report display unavailable."
+    def extract_key_results_for_selection(okr_data):
+        return []
+    def format_single_okr_for_display(okr_data, **kwargs):
+        return "Agentic modules not loaded. OKR display unavailable."
+
 
 # --- ANALYTICS TAB MODULE IMPORT ---
 from services.analytics_tab_module import AnalyticsTab
@@ -125,33 +135,83 @@ with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"),
         fn_generate_llm_response=generate_llm_response
     )
     
-    # --- NEW: Handler function for report selection ---
-    def display_selected_report(selected_report_id: str, current_token_state: dict):
+    # --- MODIFIED: Comprehensive handler for report selection and OKR display ---
+    def update_report_and_okr_display(selected_report_id: str, current_token_state: dict):
         """
-        Finds the selected report in the state and formats it for display.
+        Finds the selected report in the state, formats its text for display,
+        and crucially, fetches and reconstructs its associated OKRs and Tasks from Bubble.
+        Returns a full set of UI updates for all agentic components.
         """
+        # Define a default/error return tuple that matches the output components
+        error_return_tuple = (
+            gr.update(value="*Please select a report to view its details.*"),
+            gr.update(choices=[], value=[], interactive=False),
+            gr.update(value="*Please select a report to see OKRs.*"),
+            None,
+            [],
+            []
+        )
+
         if not selected_report_id:
-            return gr.update(value="*Please select a report from the library.*")
+            return error_return_tuple
         
         agentic_df = current_token_state.get("bubble_agentic_analysis_data")
         if agentic_df is None or agentic_df.empty:
-             return gr.update(value="*Report data not loaded. Cannot display report.*")
+            return error_return_tuple
 
-        # The dropdown value is the unique ID of the report (e.g., Bubble _id)
         selected_report_series_df = agentic_df[agentic_df['_id'] == selected_report_id]
-        
         if selected_report_series_df.empty:
-            return gr.update(value=f"*Error: Could not find report with ID {selected_report_id}.*")
+            error_return_tuple[0] = gr.update(value=f"*Error: Report with ID {selected_report_id} not found.*")
+            return error_return_tuple
             
         selected_report_series = selected_report_series_df.iloc[0]
+        
+        # 1. Format the main report text
         report_markdown = format_report_for_display(selected_report_series)
         
-        return gr.update(value=report_markdown)
+        # 2. Fetch and reconstruct the full OKR data for the selected report
+        reconstructed_data = fetch_and_reconstruct_data_from_bubble(selected_report_series)
 
+        # 3. Prepare UI updates for the OKR section based on the reconstructed data
+        if reconstructed_data:
+            raw_results_state = reconstructed_data
+            actionable_okrs_dict = reconstructed_data.get("actionable_okrs", {})
+            
+            all_krs_state = extract_key_results_for_selection(actionable_okrs_dict)
+            if all_krs_state:
+                kr_choices = [(kr['kr_description'], kr['unique_kr_id']) for kr in all_krs_state]
+                key_results_cbg_update = gr.update(choices=kr_choices, value=[], interactive=True)
+                
+                # Format all OKRs for initial display
+                okrs_list = actionable_okrs_dict.get("okrs", [])
+                output_md_parts = [
+                    format_single_okr_for_display(okr_data, okr_main_index=okr_idx)
+                    for okr_idx, okr_data in enumerate(okrs_list)
+                ]
+                okr_details_md = "\n\n---\n\n".join(output_md_parts) if output_md_parts else "No OKRs are defined in this report."
+            else:
+                key_results_cbg_update = gr.update(choices=[], value=[], interactive=False)
+                okr_details_md = "No Key Results were found for this report."
+                all_krs_state = []
+        else:
+            # Handle case where reconstruction fails
+            key_results_cbg_update = gr.update(choices=[], value=[], interactive=False)
+            okr_details_md = "Error: Could not fetch or reconstruct OKR data for this report."
+            raw_results_state = None
+            all_krs_state = []
+        
+        # 4. Return the complete set of updates for the UI
+        return (
+            report_markdown,
+            key_results_cbg_update,
+            okr_details_md,
+            raw_results_state,
+            [],  # Reset selected key results on new report selection
+            all_krs_state
+        )
 
     with gr.Tabs() as tabs:
         with gr.TabItem("1️⃣ Dashboard", id="tab_dashboard"):
-            # REMOVED: Sync button and related UI components. This tab is now just for the main dashboard.
             gr.Markdown("I dati visualizzati in questo pannello sono caricati direttamente da Bubble.io.")
             dashboard_display_html = gr.HTML("<p style='text-align:center;'>Caricamento dashboard...</p>")
 
@@ -164,7 +224,6 @@ with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"),
             agentic_pipeline_status_md = gr.Markdown("Status: Loading report data...", visible=True)
             gr.Markdown("Questo report è stato pre-generato da un agente AI e caricato da Bubble.io. Seleziona un report dalla libreria per visualizzarlo.")
             
-            # NEW: Report library dropdown
             with gr.Row():
                 report_selector_dd = gr.Dropdown(
                     label="Report Library",
@@ -173,7 +232,6 @@ with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"),
                     info="Select a previously generated report to view its details."
                 )
             
-            # This Markdown component will now display the selected report
             agentic_report_display_md = gr.Markdown("Please select a report from the library to view it.")
             
             if not AGENTIC_MODULES_LOADED:
@@ -231,21 +289,30 @@ with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"),
                     outputs=[okr_detail_display_md]
                 )
     
-    # --- NEW: Event binding for the report selector dropdown ---
+    # --- MODIFIED: Event binding for the report selector dropdown ---
+    # This now updates all agentic components, not just the report text.
     if AGENTIC_MODULES_LOADED:
+        # Define the list of outputs that the handler function will update
+        report_selection_outputs = [
+            agentic_report_display_md,
+            key_results_cbg,
+            okr_detail_display_md,
+            orchestration_raw_results_st,
+            selected_key_result_ids_st,
+            key_results_for_selection_st
+        ]
         report_selector_dd.change(
-            fn=display_selected_report,
+            fn=update_report_and_okr_display,
             inputs=[report_selector_dd, token_state],
-            outputs=[agentic_report_display_md],
+            outputs=report_selection_outputs,
             show_progress="minimal"
         )
 
-
     # --- EVENT HANDLING (SIMPLIFIED) ---
-    # MODIFIED: Define the output list for loading agentic results
+    # The output list for the initial agentic load
     agentic_display_outputs = [
         agentic_report_display_md,
-        report_selector_dd, # ADDED: The new dropdown
+        report_selector_dd,
         key_results_cbg,
         okr_detail_display_md,
         orchestration_raw_results_st,
@@ -274,11 +341,11 @@ with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"),
         ],
         outputs=analytics_tab_instance.graph_refresh_outputs_list,
         show_progress="full"
-    # Then, load and display the pre-computed agentic results
+    # Then, load and display the pre-computed agentic results, including reconstructed OKRs
     ).then(
-        fn=load_and_display_agentic_results, # This function's implementation needs to be updated
-        inputs=[token_state, orchestration_raw_results_st, selected_key_result_ids_st, key_results_for_selection_st],
-        outputs=agentic_display_outputs, # The output list is now updated
+        fn=load_and_display_agentic_results,
+        inputs=[token_state], # Inputs simplified as the function now gets everything from state
+        outputs=agentic_display_outputs,
         show_progress="minimal"
     )