Update app.py

app.py

@@ -10,27 +10,24 @@ def create_reranking_interface(task_data):
     completed_samples = {s["id"]: False for s in samples}
     
     def save_ranking(rankings, sample_id):
-        print("DEBUG: Rankings received:", rankings)
-        print("DEBUG: sample_id received:", sample_id, type(sample_id))
+        """Save the current set of rankings."""
         try:
             # Check if all documents have rankings
             all_ranked = all(r is not None and r != "" for r in rankings)
             if not all_ranked:
                 return "⚠️ Please assign a rank to all documents before submitting", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
             
-            # Convert rankings to integers
+            # Convert rankings to integers with better error handling
             try:
                 processed_rankings = [int(r) for r in rankings]
-                print("DEBUG: Processed rankings:", processed_rankings)
-            except ValueError as ve:
-                print("DEBUG: ValueError in ranking conversion:", ve)
+            except ValueError:
                 return "⚠️ Invalid ranking value. Please use only numbers.", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
             
             # Check for duplicate rankings
             if len(set(processed_rankings)) != len(processed_rankings):
                 return "⚠️ Each document must have a unique rank. Please review your rankings.", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
                 
-            # Store annotation in memory
+            # Store this annotation in memory
             existing_idx = next((i for i, a in enumerate(results["annotations"]) if a["sample_id"] == sample_id), None)
             if existing_idx is not None:
                 results["annotations"][existing_idx] = {
@@ -43,23 +40,20 @@ def create_reranking_interface(task_data):
                     "rankings": processed_rankings
                 })
             
-            # Convert sample_id if necessary
-            if sample_id not in completed_samples:
-                try:
-                    sample_id = int(sample_id)
-                except:
-                    pass
-            print("DEBUG: Completed samples keys:", completed_samples.keys())
             completed_samples[sample_id] = True
             
-            output_path = f"{task_data['task_name']}_human_results.json"
-            with open(output_path, "w") as f:
-                json.dump(results, f, indent=2)
-            return "✅ Rankings saved successfully", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
+            # Try to save to file, but continue even if it fails
+            try:
+                output_path = f"{task_data['task_name']}_human_results.json"
+                with open(output_path, "w") as f:
+                    json.dump(results, f, indent=2)
+                return f"✅ Rankings saved successfully (in memory and to file)", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
+            except:
+                # If file saving fails, still mark as success since we saved in memory
+                return f"✅ Rankings saved in memory (file save failed)", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
         except Exception as e:
-            print("DEBUG: Exception occurred:", e)
+            # Return specific error message
             return f"Error: {str(e)}", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
-
     
     with gr.Blocks(theme=gr.themes.Soft()) as demo:
         gr.Markdown(f"# {task_data['task_name']} - Human Reranking Evaluation")
@@ -186,9 +180,16 @@ def create_reranking_interface(task_data):
                 json.dump(results, f, indent=2)
             return f"✅ Results saved to {output_path} ({len(results['annotations'])} annotations)"
         
+        # Define a wrapper function that collects all the dropdown values into a list
+        def save_ranking_wrapper(*args):
+            # The last argument is the sample_id, all others are rankings
+            rankings = args[:-1]
+            sample_id = args[-1]
+            return save_ranking(rankings, sample_id)
+        
         # Connect events
         submit_btn.click(
-            save_ranking,
+            save_ranking_wrapper,
             inputs=ranking_dropdowns + [current_sample_id],
             outputs=[status_box, progress_text]
         )