Update app.py

app.py

@@ -13,7 +13,7 @@ def create_reranking_interface(task_data):
         """Save the current set of rankings."""
         try:
             # Check if all documents have rankings
-            all_ranked = all(r is not None and r != "" for r in rankings)
+            all_ranked = all(r is not None and r != "" and r != 0 for r in rankings)
             if not all_ranked:
                 return "⚠️ Please assign a rank to all documents before submitting", f"Progress: {sum(completed_samples.values())}/{len(samples)}"
             
@@ -98,6 +98,8 @@ def create_reranking_interface(task_data):
                             label=f"Document {i+1}",
                             interactive=False
                         )
+                        doc_containers.append(doc_box)  # Add to doc_containers list
+                        
                         with gr.Column():
                             rank_number = gr.Number(
                                 value=0,  # Start with 0 
@@ -107,18 +109,31 @@ def create_reranking_interface(task_data):
                                 step=1,
                                 precision=0  # Integer only
                             )
+                            ranking_dropdowns.append(rank_number)  # Add to ranking_dropdowns list
+                            
                             with gr.Row():
                                 up_btn = gr.Button("↑", size="sm")
                                 down_btn = gr.Button("↓", size="sm")
                         
-                        # Connect up/down buttons to increase/decrease rank
+                        # Create proper closures for the button handlers
+                        def make_up_handler(idx):
+                            def up_handler(x):
+                                return max(1, x-1)
+                            return up_handler
+                        
+                        def make_down_handler(idx, max_val):
+                            def down_handler(x):
+                                return min(max_val, x+1)
+                            return down_handler
+                        
+                        # Connect up/down buttons to increase/decrease rank with proper handlers
                         up_btn.click(
-                            lambda x: max(1, x-1),  # Lower number = higher rank
+                            make_up_handler(i),
                             inputs=[rank_number],
                             outputs=[rank_number]
                         )
                         down_btn.click(
-                            lambda x: min(len(samples[0]["candidates"]), x+1),
+                            make_down_handler(i, len(samples[0]["candidates"])),
                             inputs=[rank_number],
                             outputs=[rank_number]
                         )
@@ -134,7 +149,7 @@ def create_reranking_interface(task_data):
             """Load a specific sample into the interface."""
             sample = next((s for s in samples if s["id"] == sample_id), None)
             if not sample:
-                return [query_text.value] + [d.value for d in doc_containers] + [""] * len(ranking_dropdowns) + [current_sample_id.value, progress_text.value, status_box.value]
+                return [query_text.value] + [d.value for d in doc_containers] + [0] * len(ranking_dropdowns) + [current_sample_id.value, progress_text.value, status_box.value]
             
             # Update query
             new_query = sample["query"]
@@ -146,7 +161,7 @@ def create_reranking_interface(task_data):
                     new_docs.append(doc)
                     
             # Initialize rankings
-            new_rankings = [""] * len(ranking_dropdowns)
+            new_rankings = [0] * len(ranking_dropdowns)
             
             # Check if this sample has already been annotated
             existing_annotation = next((a for a in results["annotations"] if a["sample_id"] == sample_id), None)
@@ -154,7 +169,7 @@ def create_reranking_interface(task_data):
                 # Restore previous rankings
                 for i, rank in enumerate(existing_annotation["rankings"]):
                     if i < len(new_rankings) and rank is not None:
-                        new_rankings[i] = str(rank)
+                        new_rankings[i] = rank
             
             # Update progress
             current_idx = samples.index(sample)